Mingw friendly case for includes. #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. By chance, would you be able to add a GitHub action (or another CI) that tests the "mingw" case? |
|
I'm not really familiar with Github actions; is there already a CI environment cross compiling with mingw ? |
I don't know. Maybe ask the people who're into "windows" and "OCaml" - they must have some secret runes how to test their projects in CI / GitHub actions. |
|
Thanks. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Jan 30, 2025
CHANGES:
Provide thread safety (Unix.fork and multi-domain safe) RNG generators by using
getrandom/getentropy on UNIX (or /dev/urandom). In your UNIX applications,
please use the "mirage-crypto-rng.unix" dependency and call
"Mirage_crypto_rng_unix.use_default ()" (instead of depending on
mirage-crypto-rng-{lwt,eio,async} and calling
"Mirage_crypto_rng_{eio,lwt,async}.initialize".
* mirage-crypto-rng: handle CPU_RNG failures (mirage/mirage-crypto#255 @hannesm, addresses mirage/mirage-crypto#251 mirage/mirage-crypto#252
mirage/mirage-crypto#253)
* mirage-crypto-rng.unix: provide two generators: Urandom and Getentropy
(mirage/mirage-crypto#250 @hannesm @reynir @edwintorok, addresses mirage/mirage-crypto#249)
* mirage-crypto-rng: deprecate the initialize for lwt, async, eio (and
advertise `Mirage_crypto_rng_unix.use_default ()` (mirage/mirage-crypto#254 @hannesm)
* mirage-crypto-rng-eio: declare the cstruct dependency (mirage/mirage-crypto#247 @hannesm)
* include "windows.h" (all lowercase) (mirage/mirage-crypto#248 @mefyl)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since windows filesystem is case insensitive and, AFAIK,
windows.his always lowercase in MinGW distributions, using a lowercase include will work on both transparently.Currently: